Skip to content

Conversation

@kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 31, 2025

This PR implements simp? +suggestions, which uses the configured library suggestion engine to add relevant theorems to the simp call. simp +suggestions without the ? prints a message requiring adding the ?.

@kim-em kim-em requested a review from digama0 as a code owner October 31, 2025 04:35
@kim-em kim-em added the changelog-tactics User facing tactics label Oct 31, 2025
@kim-em kim-em enabled auto-merge October 31, 2025 04:42
@kim-em kim-em added this pull request to the merge queue Nov 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 3, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0db89d65b27b56ea911add501cf041dfc44976a1 --onto 1ce05b2a179eac8a902995c0caddc609c0169c49. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-03 01:36:22)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 0db89d65b27b56ea911add501cf041dfc44976a1 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-11-03 01:36:23)

@kim-em kim-em changed the title feat: simp? +suggestion feat: simp? +suggestions Nov 3, 2025
@kim-em kim-em enabled auto-merge November 3, 2025 02:33
@kim-em kim-em added this pull request to the merge queue Nov 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2025
@kim-em kim-em enabled auto-merge November 3, 2025 03:12
@kim-em kim-em added this pull request to the merge queue Nov 3, 2025
Merged via the queue into master with commit b8bd91d Nov 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-tactics User facing tactics toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants