[Backport releases/v4.32.0] fix: avoid compiler panic when deriving computable Inhabited in a noncomputable section#14128
Merged
Conversation
…noncomputable section` (#14125) This PR fixes a compiler panic that occurred when deriving a computable `Inhabited` instance for a type inside a `noncomputable section`. The derived auxiliary default function was added to the environment but not compiled, while the still-computable instance referencing it was compiled, hitting an `unreachable!` in the `ExplicitBoxing` LCNF pass. The aux function is now always compiled like a regular `def`, suppressing errors in a `noncomputable section` so that a default depending on noncomputable code marks the aux (and hence the instance built from it) noncomputable instead of leaving it uncompiled while the computable instance still references it. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 0a0e533)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 0a0e533 from #14125.