feat: TCP socket support using LibUV #6683
Conversation
Co-authored-by: Henrik Böving <[email protected]>
This PR adds support for `Timer` and a event loop thread that gets requests from another threads and executes it. --------- Co-authored-by: Markus Himmel <[email protected]> Co-authored-by: Henrik Böving <[email protected]>
This PR implements a basic asynchronous timer API on top of the libuv work. It purposely puts this into `Std.Internal` as we might still have to change the API as we continue develop of the async library across releases so I would only like to stabilize it once we are certain this is a fine API. A few additional notes: - we currently do not implement a bind operator on `AsyncTask` on purpose as `Task.bind` on `Task.pure` is a non trivial operation and users should be aware of it. Furthermore there is the consideration that as they will have to bind on both `IO` and `AsyncTask` we might want to make potential task points explicit in the syntax (did somebody say `await`?). - the API generally takes inspiration from https://docs.rs/tokio/latest/tokio/time/index.html, though it has to adapt as Rust's and Lean's asynchronity concepts are sufficiently different. Stacked on top of leanprover#6219.
m# git update-ref -d MERGE_HEAD
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
There was a problem hiding this comment.
I think this is very promising now! There's mostly on memory leaks and stylistic things left but the implementation looks like it should be able to work now.
Beyond these issues it would of course be great if we could also have some tests like for Timer that exercise this API. I would assume you can just connect to localhost and do an echo or something like that? Of course we should have tests for both IPv4 and v6.
After we have those tests I guess it might also be a good idea to write a little benchmark to see how many TCP connections we can handle per second to get an estimate of what kind of load we can expect to handle at best given this implementation.
| } | ||
|
|
||
| /* Std.Internal.UV.Tcp.Socket.recv (socket : @& Socket) : IO (IO.Promise (Except IO.Error ByteArray)) */ | ||
| extern "C" LEAN_EXPORT lean_obj_res lean_uv_tcp_recv(b_obj_arg socket) { |
There was a problem hiding this comment.
As we seem to be approaching a final version of this now. It would be great if we could pass a size : USize into recv to tell the size of the buf to allocate instead of always taking libuvs suggestion. That should be doable right?
This PR introduces TCP socket support using the LibUV library, enabling asynchronous I/O operations with it.