feat: make core app unexpanders tag tokens #6704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes a number of app unexpanders tag the tokens that appear in the syntax with the head constant when in `pp.tagAppFns` mode. This affects docgen; for example, `∃` now links to `Exists` in documentation. These are the notations that have been modified: - `Prod.mk` - `ite` - `Eq.ndrec` and `Eq.rec` (`▸`) - `Exists` - `Sigma` - `PSigma` - `Subtype` - `GetElem.getElem`, `getElem!`, and `getElem?` - `singleton` and `insert`
|
Another solution could be to make app unexpanders start with the head function as the ref, removing the need for manually writing |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of app unexpanders tag the tokens that appear in the syntax with the head constant when in
pp.tagAppFnsmode. This affects docgen; for example,∃now links toExistsin documentation. These are the app unexpanders that have been modified:Prod.mkiteEq.ndrecandEq.rec(▸)ExistsSigmaPSigmaSubtypeGetElem.getElem,getElem!, andgetElem?singletonandinsertNote that this causes all tokens to be linked. For example, the
,inExistsnotation is also a link toExists.