Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make IntX constructor private, provide UIntX.toIntX #7062

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: make IntX constructor private, provide UIntX.toIntX #7062

merged 2 commits into from
Feb 13, 2025
+25 −0

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Feb 13, 2025

This PR introduces the functions UIntX.toIntX as the public API to obtain the IntX that is 2's complement equivalent to a given UIntX.

@TwoFX TwoFX added the changelog-library Library label Feb 13, 2025
@TwoFX TwoFX requested a review from kim-em as a code owner February 13, 2025 09:17
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 13, 2025 09:25 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 13, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1ecb4a43aeee6d24322f5cc03233d291fdf34a43 --onto 07b0e5b7fe596178282214a5c29f42e555bba59b. (2025-02-13 09:46:01)

@TwoFX TwoFX added this pull request to the merge queue Feb 13, 2025
@TwoFX TwoFX removed this pull request from the merge queue due to a manual request Feb 13, 2025
@TwoFX TwoFX enabled auto-merge February 13, 2025 11:12
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 13, 2025 11:19 Inactive
@TwoFX TwoFX added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit a3fd2eb Feb 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoFX @leanprover-community-bot