Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename BitVec.ofNatLt -> BitVec.ofNatLT #7064

Merged
merged 3 commits into from
Feb 13, 2025
Merged

chore: rename BitVec.ofNatLt -> BitVec.ofNatLT #7064

merged 3 commits into from
Feb 13, 2025
+51 −36

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Feb 13, 2025

This PR renames BitVec.ofNatLt to BitVec.ofNatLT and sets up deprecations for the old name.

@TwoFX TwoFX added the changelog-library Library label Feb 13, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 13, 2025 11:07 Inactive
@TwoFX TwoFX marked this pull request as ready for review February 13, 2025 11:12
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Feb 13, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#7064
432762d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Feb 13, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#7064
09cfe47
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Feb 13, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Feb 13, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-7064 has successfully built against this PR. (2025-02-13 12:08:28) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a3fd2eb0fef700b17f1239ff1ec26f733343d1f5 --onto 07b0e5b7fe596178282214a5c29f42e555bba59b. (2025-02-13 12:47:13)

@TwoFX TwoFX added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 13, 2025 12:35 Inactive
@TwoFX TwoFX added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit b38da34 Feb 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoFX @leanprover-community-bot