Used State to Make Page Dynamic #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Jun 12, 2024
| // replace 'false' with a state variable that can be toggled between true and false | ||
| // this will be used for the Dark Mode Toggle feature | ||
| const appClass = false ? "App dark" : "App light" | ||
| const [count, setCount] = useState(false) |
There was a problem hiding this comment.
Can you think of a better name than count? What is really being stored in that variable?
Comment on lines
+5
to
+6
| const updateClass = count ? 'in-cart' : '' | ||
| const updateButtonText = count ? 'Remove From Cart' : 'Add to Cart' |
There was a problem hiding this comment.
When you prefix with update, that implies that something is updated. While that's kind of true in this case, it's not entirely true and there is a better name. Something like itemClass implies that it will be returning a a class name for the item, and buttonClass is less redundant. It's subjective, but what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used state to populate shopping list based on drop down menu and toggle light and dark mode.