Task - 1 Done by Tahseen Alaa. #2
Conversation
| margin: 50px auto auto 50px; | ||
| text-align: center; | ||
| left: 20%; | ||
| } |
There was a problem hiding this comment.
header
you don't need just remote it left: 20%. Also you can use short hand property for margin: 50px auto;
| } | ||
|
|
||
| section { | ||
| text-align: center; |
There was a problem hiding this comment.
useless just remote it
| padding: 50px 50px 50px 50px; | ||
| left: 27%; | ||
| text-align: center; | ||
| } |
There was a problem hiding this comment.
backSpace
as you can see in the image below, your layout is broken!! the reason is left: 27% do you know the purpose of left property? you can't use it everywhere be careful with that. Remove position, text-align Also, use shorthand for margin: 100px auto 50px and padding: 50px
| background-color: #1ECDE2; | ||
| color: #fff; | ||
| } | ||
|
|
There was a problem hiding this comment.
why you are using multiple classes for active buttons ?
you use an .active class instead of these.btn1, .btn2, .btn6, .btn11 and then use it in your button tags!
There was a problem hiding this comment.
I thought I will need it later, and forget to delete them.
| <div class=""> | ||
| <button class="btn btn1">C</button> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
remove all <div class=""> since they don't have class!
There was a problem hiding this comment.
the whole code need minify before deploy as production.
thanks for the review.
I fixed all bugs.
2 participants
Task - 1 Done by Tahseen Alaa.
Added to Solutions Branch.