Tests #17
Open
Tests #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res.send({ | ||
| type: 'start', | ||
| type: 'ready', |
There was a problem hiding this comment.
I think I added in the type property trying to add some functionality in the last week of dev - but realised I didn't need it at all. I can't confirm this second, but have a feeling this whole line can be removed.
There was a problem hiding this comment.
Ignore me, I checked start.js and it is used....
There was a problem hiding this comment.
Blimey - right, I realise what's happened here, the diff has said it's a change from 'start' to 'ready' which now looking makes no sense, otherwise the game would have never started, but in fact github is diffing two completely different lines - hence my confusion!
added 11 commits
May 22, 2013 11:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.