Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix read_ldata #89

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Bug Fix read_ldata #89

merged 2 commits into from
Jan 24, 2025

Conversation

theHenks
Copy link
Collaborator

Included ignore_missing kwarg in read_ldata to be able to ignore missing channels. In particular useful for Water Cherenkov PMT analysis.

raw = read_ldata(l200, DataTier(:raw), :phy, :p03, :r000, ch; ignore_missing=true)

@theHenks theHenks added the bug Something isn't working label Jan 24, 2025
@theHenks theHenks requested a review from fhagemann January 24, 2025 13:36
@theHenks theHenks self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.00%. Comparing base (a660e56) to head (485fa64).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendDataManagementLegendHDF5IOExt.jl 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   42.08%   42.00%   -0.09%     
==========================================
  Files          26       26              
  Lines        1972     1976       +4     
==========================================
  Hits          830      830              
- Misses       1142     1146       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann merged commit f559492 into main Jan 24, 2025
9 of 11 checks passed
@theHenks theHenks deleted the patch_runinfo branch January 24, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants