Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pangocffi v0.11.0 + Use property() for setting resolution #29

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

leifgehrmann
Copy link
Owner

Changes in pangocffi v0.11.0 are expected that will change a lot of the API calls to use property() pattern. See leifgehrmann/pangocffi#47

This PR updates the dependency version and API calls to support the new notation.

This PR also:

  • Updates the FontMap's resolution to use the property() pattern as well.
  • Updates tox.ini to include py310.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Base: 75.00% // Head: 75.48% // Increases project coverage by +0.48% 🎉

Coverage data is based on head (bc6b5a7) compared to base (f60412e).
Patch coverage: 64.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   75.00%   75.48%   +0.48%     
==========================================
  Files           6        6              
  Lines         152      155       +3     
==========================================
+ Hits          114      117       +3     
  Misses         38       38              
Impacted Files Coverage Δ
pangocairocffi/create_update_functions.py 61.11% <0.00%> (ø)
pangocairocffi/font_functions.py 42.10% <0.00%> (ø)
pangocairocffi/render_functions.py 80.95% <ø> (ø)
pangocairocffi/font_map.py 85.71% <100.00%> (+0.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leifgehrmann leifgehrmann merged commit 2cbf21e into master Oct 7, 2022
@leifgehrmann leifgehrmann deleted the pythonic branch October 7, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants