mathieu/feature/Edit email in App if admin

[macteuts]

No description provided.

[ladislas]

good job! 👍 I've added some requests to the review

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR introduces changes to support editing emails in the App, with added logic for handling admin caregivers and verifying email changes. Key changes include:

• Adding an isAdmin property to the Caregiver model and updating its initialization and JSON coding keys.
• Implementing new email update logic in AuthManager with email verification before changing the email.
• Adding new views (ChangeEmailView and EnterNewEmailView) and updating SettingsView to allow email re-authentication and change for admin caregivers, along with corresponding localization updates.

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Modules/AccountKit/Sources/Models/CaregiverModel/Caregiver.swift	Added optional isAdmin property with default false and updated CodingKeys.
Modules/AccountKit/Sources/Models/CaregiverModel/Caregiver+Init.swift	Extended initializer to include isAdmin, and assigned it accordingly.
Modules/AccountKit/Sources/Managers/Caregivers/CaregiverManager.swift	Updated caregiver data payload and added delete-caregiver logic to prevent admin deletion.
Modules/AccountKit/Sources/Authentication/AuthManager.swift	Added email verification logic before updating email and new user action state.
Apps/LekaApp/Sources/Views/Settings/SettingsView.swift	Introduced a ChangeEmailView button displayed conditionally for admin caregivers.
Apps/LekaApp/Sources/Views/Settings/SettingsView+l10n.swift	Added localization for the Change Email button label.
Apps/LekaApp/Sources/Views/EnterNewEmailView.swift	Implemented a new view for entering a new email address with email verification trigger.
Apps/LekaApp/Sources/Views/EnterNewEmailView+l10n.swift	Added localization strings for the EnterNewEmailView.
Apps/LekaApp/Sources/Views/ChangeEmailView.swift	Implemented a view for confirming email change via password re-authentication.
Apps/LekaApp/Sources/Views/ChangeEmailView+l10n.swift	Added localization strings for the ChangeEmailView.

Files not reviewed (1)

• Apps/LekaApp/Resources/l10n/Localizable.xcstrings: Language not supported

Comments suppressed due to low confidence (1)

Modules/AccountKit/Sources/Models/CaregiverModel/Caregiver.swift:27

• [nitpick] Consider making 'isAdmin' a non-optional Bool instead of Bool? since it always defaults to false, which could simplify the code by removing the need for optional unwrapping.

public var isAdmin: Bool? = false

[sonarqubecloud]

Quality Gate failed

Failed conditions
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud