Allow string and bigints for number formatting

lemonmade · Jun 9, 2024 · 05951a2 · 05951a2
1 parent 01945eb
commit 05951a2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/.changeset/tiny-badgers-burn.md b/.changeset/tiny-badgers-burn.md
@@ -0,0 +1,5 @@
+---
+'@quilted/localize': patch
+---
+
+Allow string and bigints for number formatting
diff --git a/packages/localize/source/formatting.ts b/packages/localize/source/formatting.ts
@@ -23,14 +23,14 @@ export interface LocalizedFormatting {
     LocalizedDateTimeFormatOptions
   >;
   formatNumber(
-    number: number,
+    number: number | bigint | string,
     options?: Omit<
       LocalizedNumberFormatOptions,
       'currencySign' | 'currencyDisplay'
     >,
   ): string;
   formatCurrency(
-    amount: number,
+    amount: number | bigint | string,
     options: Omit<LocalizedNumberFormatOptions, 'currency' | 'style'> & {
       currency: string;
     },
@@ -59,12 +59,16 @@ export function createLocalizedFormatting(locale: string): LocalizedFormatting {
     numberFormatter,
     dateTimeFormatter,
     formatNumber(number, options) {
+      // @ts-expect-error NumberFormat.format() should accept string
       return numberFormatter.get(options).format(number);
     },
     formatCurrency(amount, options) {
-      return numberFormatter
-        .get({...options, style: 'currency'})
-        .format(amount);
+      return (
+        numberFormatter
+          .get({...options, style: 'currency'})
+          // @ts-expect-error NumberFormat.format() should accept string
+          .format(amount)
+      );
     },
     formatDate(date, options) {
       return dateTimeFormatter.get(options).format(date);