Skip to content

Add new, cleaner Trigger syntax #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 51 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
30989a8
Convert project to TypeScript
adroitwhiz Mar 8, 2023
5a9c8c1
Specify function return types
adroitwhiz Mar 8, 2023
77fce3b
Assume Sprite._project exists always
adroitwhiz Mar 8, 2023
3d3a21d
Remove ".js" suffix from imports
adroitwhiz Mar 8, 2023
182903e
Add visibility modifiers to all class members
adroitwhiz Mar 8, 2023
72ad027
Add effect properties to AudioEffectMap
adroitwhiz Mar 8, 2023
93e0b40
Remove ESLint comment from abstract method
adroitwhiz Mar 8, 2023
32312f6
Port toBoolean + compare to TypeScript
adroitwhiz Mar 8, 2023
3d8cd82
Fix edge-activated trigger handling
adroitwhiz Mar 8, 2023
c64ff04
Clean up _startTriggers
adroitwhiz Mar 8, 2023
22b5276
Change spritesAndStage signature
adroitwhiz Mar 8, 2023
f36b5d3
Whitespace tweak in Input
adroitwhiz Mar 8, 2023
cbc69b6
Unify constructor param types
adroitwhiz Mar 8, 2023
aa4cc24
Clarify _getSkin signature
adroitwhiz Mar 8, 2023
07a51bf
Swap _setShader if/else
adroitwhiz Mar 8, 2023
6e433a2
Replace typeof with truthiness check
adroitwhiz Mar 8, 2023
befbb27
Make createStage private and static
adroitwhiz Mar 8, 2023
fd84bc5
export RGBA/RGBANormalized types
adroitwhiz Mar 8, 2023
bf83d86
Allow checkPointCollision for Stage
adroitwhiz Mar 8, 2023
6f8bf77
Be more consistent with Sound field types
adroitwhiz Mar 8, 2023
de67e35
Clean up effect descriptor types + docs
adroitwhiz Mar 8, 2023
be448a9
Remove EffectChain.config
adroitwhiz Mar 8, 2023
d7c41bd
Remove "infer" from effectNodes type
adroitwhiz Mar 8, 2023
de8767d
Move Trigger symbols to Trigger class
adroitwhiz Mar 8, 2023
36745e5
Fix "as never" cast
adroitwhiz Mar 8, 2023
6116434
Remove boundScript
adroitwhiz Mar 8, 2023
db0e775
Remove vars default parameter
adroitwhiz Mar 8, 2023
1059590
Override Stage costumeNumber
adroitwhiz Mar 8, 2023
bdb5751
Make costumeNumber match Scratch
adroitwhiz Mar 8, 2023
c361068
Override askAndWait
adroitwhiz Mar 8, 2023
b652c4a
Remove TODO
adroitwhiz Mar 8, 2023
eb9427e
Type moveAhead/moveBehind better
adroitwhiz Mar 8, 2023
bb478ac
Add extra _speechBubble check to fix typing
adroitwhiz Mar 8, 2023
d34a9da
Document getTexture/getImageData
adroitwhiz Mar 8, 2023
24ed04d
Add flipped getter
adroitwhiz Mar 8, 2023
3323792
SpeechBubbleStyle type
adroitwhiz Mar 8, 2023
5d467a6
Fix unnecessary initialized assertions
adroitwhiz Mar 8, 2023
f9cd056
Fix watcher min/max/step init
adroitwhiz Mar 8, 2023
349e0ed
Move filter param
adroitwhiz Mar 8, 2023
c5c0b65
Make _project and _layerOrder protected
adroitwhiz Mar 8, 2023
071d842
Remove vars type parameter
adroitwhiz Mar 9, 2023
2f45fc3
Make clone methods return subclass type
adroitwhiz Mar 9, 2023
5cae173
Remove unnecessary instanceof
adroitwhiz Mar 9, 2023
88c3609
Format + lint
adroitwhiz Mar 9, 2023
c7ac249
Fix Sound.clone
adroitwhiz Mar 9, 2023
d1b6ae6
Bump Node to 18
adroitwhiz Mar 10, 2023
8a42763
WIP: new Trigger interface
towerofnix Mar 11, 2023
9f7eca2
integrate new Trigger interfaces
towerofnix Mar 11, 2023
aee4a06
quick trigger fixes for compatibility/naming
towerofnix Mar 12, 2023
545d7e7
warn first time each deprecated Trigger symbol is used
towerofnix Mar 12, 2023
4c03b2a
documentation & variable name fixes
towerofnix Mar 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,38 @@
"ecmaVersion": 9,
"sourceType": "module"
},
"plugins": ["prettier"],
"extends": ["eslint:recommended", "plugin:prettier/recommended"],
"plugins": ["@typescript-eslint", "prettier"],
"extends": [
"eslint:recommended",
"plugin:prettier/recommended"
],
"env": {
"browser": true,
"es6": true
},
"rules": {
"no-console": ["warn", {"allow": ["warn", "error"]}]
}
},
"overrides": [
{
"files": ["src/**/*"],
"parserOptions": {
"parser": "@typescript-eslint/parser",
"project": "./tsconfig.json"
},
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking"
],
"env": {
"browser": true
},
"rules": {
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/explicit-member-accessibility": "error",
"@typescript-eslint/prefer-return-this-type": "error",
"@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}]
}
}
]
}
4 changes: 2 additions & 2 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
# - uses: actions/checkout@v3
# - uses: actions/setup-node@v3
# with:
# node-version: 16
# node-version: 18
# - run: npm ci
# - run: npm test

Expand All @@ -25,7 +25,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm publish
Expand Down
Loading