Skip to content

Conversation

maccesch
Copy link
Contributor

I also added <ShowLet> to a few appropriate places in the examples. This way it should be properly tested in the future.

This should fix #4254 and #4236

@maccesch
Copy link
Contributor Author

CI seems to be broken still... the errors don't seem to come from my changes

@benwis
Copy link
Contributor

benwis commented Aug 27, 2025

Is this trying to only work in Stable?

@maccesch
Copy link
Contributor Author

I get why it might look this way. But no, this works now in both, stable and nightly.

The reason to exclude some code on nightly is simply because in nightly signals are functions. That means my two implementations for signals and functions collide. In stable signals are not functions so there we need the extra implementation.

@sabify
Copy link
Contributor

sabify commented Aug 28, 2025

@gbj @benwis, I've seen many times that a PR gets merged without a successful CI run; In case we have a failed CI due to network/unusual issues, please re-run the workflow/job manually.

  1. Go to the "Actions" tab
  2. Find the failed workflow run associated with your PR
  3. Click on the workflow run
  4. Click "Re-run jobs" or "Re-run failed jobs" button

@zakstucke
Copy link
Collaborator

I think these changes to Show and co would be superseded by #4273 if merged.

After #4273, #[prop(into)] when: Signal<bool> would natively work for true, || true, Signal::derive(|| true) etc.

@maccesch
Copy link
Contributor Author

I think these changes to Show and co would be superseded by #4273 if merged.

After #4273, #[prop(into)] when: Signal<bool> would natively work for true, || true, Signal::derive(|| true) etc.

That would be very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues compiling empty projects
4 participants