Repository sanitation for branch 2.4#25
Open
congma wants to merge 6 commits intolesgourg:2.4from
Open
Conversation
The repo is currently in a state of inconsistent end-of-line (EOL) character usage. This commit attempts to fix it as recommended by the manual gitattributes(5).
It is not enough to just exclude them in .gitignore rules. They must be removed from the index so that they are no longer tracked in the future. The `output/` directory now includes its own .gitignore file, so that the directory will be created when doing a checkout. This helps prevent path-not-found error when running class from the repo directory.
The `clean` target now cleans the `class` executable file. It no longer requires the (unnecessary) `.base` target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Julien,
Here are my sanitation fixes for the Class repo.
.gitattributesfile to normalize them to LF in the Git index. Future revisions to the files will be included into the index in normalized forms. Contributors and users can still determine what EOL character they'd like to use in their working trees through Git local/global configuration options (see the man page gitattributes(5), especially the sections concerningcore.autocrlfandcore.eol.output/had been interned into the index since before they were excluded by.gitignore. Therefore, subsequent writes to such same files (possibly due to the user tweaking theexplanatory.inifile and runclassagain) will show up as revisions, rendering the exclusion useless. I removed them from the index (git rm --cache) and created a.gitignorefile in theoutput/directory, so that the directory itself can be re-created on checkout (with nothing but its.gitignorefile). For this to work, the main.gitignorefile is revised accordingly..gitignorefile and defaultMakefile.Hope they'd be useful and not cause more troubles ;)
Best wishes,
Cong.