Remove python integration test in-the-past scaffolding#8086
Conversation
08ea010 to
88a6295
Compare
|
I like the idea of saving 30 seconds on our integration tests, and I agree that this code is stable and going away soon with the removal of OCSP services. But we shouldn't land this before the actual removal of OCSP services, since we are still responsible for correct operation until then. Let's hold this PR until that happens. Other than the question of timing, looks good. Also lol that |
88a6295 to
c1d59d0
Compare
jsha
left a comment
There was a problem hiding this comment.
Looks good. It appears there is also an uncalled get_future_output that we could remove.
I assume we'll also remove the FAKECLOCK support in Boulder itself as a followup to this?
|
Good point! I'll do both of those in a followup: #8356 |
Remove the "setup_six_months_ago" and "setup_twenty_days_ago" scaffolding in our python integration test harness, which (with the removal of the last OCSP tests) no longer has any users. This simplifies that python code and reduces integration test runtime by about 30 seconds.
Part of #4934
Warning
Do not merge until #8344 has been merged