Skip to content

fix: wrong return type and endpoint path for embedding model list #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −12
Open

fix: wrong return type and endpoint path for embedding model list #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d28dc12
fix: wrong return type and endpoint path for embedding model list
adar2378 Sep 17, 2025
f86647a
Merge remote-tracking branch 'upstream/main'
adar2378 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/letta_client/models/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from ..core.client_wrapper import AsyncClientWrapper, SyncClientWrapper
from ..core.request_options import RequestOptions
from ..types.embedding_config import EmbeddingConfig
from ..types.llm_config import LlmConfig
from ..types.provider_category import ProviderCategory
from ..types.provider_type import ProviderType
Expand Down Expand Up @@ -72,7 +73,7 @@ def list(
)
return _response.data

def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions] = None) -> None:
def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions] = None) -> typing.List[EmbeddingConfig]:
"""
Parameters
----------
Expand All @@ -81,7 +82,7 @@ def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions

Returns
-------
None
typing.List[EmbeddingConfig]

Examples
--------
Expand Down Expand Up @@ -166,7 +167,7 @@ async def main() -> None:
)
return _response.data

async def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions] = None) -> None:
async def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions] = None) -> typing.List[EmbeddingConfig]:
"""
Parameters
----------
Expand All @@ -175,7 +176,7 @@ async def listembeddingmodels(self, *, request_options: typing.Optional[RequestO

Returns
-------
None
typing.List[EmbeddingConfig]

Examples
--------
Expand Down
31 changes: 23 additions & 8 deletions src/letta_client/models/raw_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from ..core.request_options import RequestOptions
from ..core.unchecked_base_model import construct_type
from ..errors.unprocessable_entity_error import UnprocessableEntityError
from ..types.embedding_config import EmbeddingConfig
from ..types.http_validation_error import HttpValidationError
from ..types.llm_config import LlmConfig
from ..types.provider_category import ProviderCategory
Expand Down Expand Up @@ -82,7 +83,7 @@ def list(
raise ApiError(status_code=_response.status_code, headers=dict(_response.headers), body=_response.text)
raise ApiError(status_code=_response.status_code, headers=dict(_response.headers), body=_response_json)

def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions] = None) -> HttpResponse[None]:
def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions] = None) -> HttpResponse[typing.List[EmbeddingConfig]]:
"""
Parameters
----------
Expand All @@ -91,16 +92,23 @@ def listembeddingmodels(self, *, request_options: typing.Optional[RequestOptions

Returns
-------
HttpResponse[None]
HttpResponse[typing.List[EmbeddingConfig]]
"""
_response = self._client_wrapper.httpx_client.request(
"v1/models/embeddings",
"v1/models/embedding",
method="GET",
request_options=request_options,
)
try:
if 200 <= _response.status_code < 300:
return HttpResponse(response=_response, data=None)
_data = typing.cast(
typing.List[EmbeddingConfig],
construct_type(
type_=typing.List[EmbeddingConfig], # type: ignore
object_=_response.json(),
),
)
return HttpResponse(response=_response, data=_data)
_response_json = _response.json()
except JSONDecodeError:
raise ApiError(status_code=_response.status_code, headers=dict(_response.headers), body=_response.text)
Expand Down Expand Up @@ -176,7 +184,7 @@ async def list(

async def listembeddingmodels(
self, *, request_options: typing.Optional[RequestOptions] = None
) -> AsyncHttpResponse[None]:
) -> AsyncHttpResponse[typing.List[EmbeddingConfig]]:
"""
Parameters
----------
Expand All @@ -185,16 +193,23 @@ async def listembeddingmodels(

Returns
-------
AsyncHttpResponse[None]
AsyncHttpResponse[typing.List[EmbeddingConfig]]
"""
_response = await self._client_wrapper.httpx_client.request(
"v1/models/embeddings",
"v1/models/embedding",
method="GET",
request_options=request_options,
)
try:
if 200 <= _response.status_code < 300:
return AsyncHttpResponse(response=_response, data=None)
_data = typing.cast(
typing.List[EmbeddingConfig],
construct_type(
type_=typing.List[EmbeddingConfig], # type: ignore
object_=_response.json(),
),
)
return AsyncHttpResponse(response=_response, data=_data)
_response_json = _response.json()
except JSONDecodeError:
raise ApiError(status_code=_response.status_code, headers=dict(_response.headers), body=_response.text)
Expand Down