Skip to content

Skip benign 404 control-flow defects in error tracking #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
posthog-eu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Skip benign 404 control-flow defects in error tracking #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions apps/api/src/observability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import * as FetchHttpClient from "effect/unstable/http/FetchHttpClient";
import * as HttpEffect from "effect/unstable/http/HttpEffect";
import * as HttpMiddleware from "effect/unstable/http/HttpMiddleware";
import * as HttpServerRequest from "effect/unstable/http/HttpServerRequest";
import * as HttpServerResponse from "effect/unstable/http/HttpServerResponse";
import * as HttpTraceContext from "effect/unstable/http/HttpTraceContext";
import * as Otlp from "effect/unstable/observability/Otlp";
import { Resource } from "sst/resource/cloudflare";
Expand Down Expand Up @@ -124,6 +125,27 @@ export namespace Observability {
const posthog = yield* Posthog.Service;

function captureUnexpectedDefect(defect: unknown, request: RequestContext.Interface) {
// Internet vulnerability scanners constantly probe non-existent routes (`/.env`,
// `/.git/config`, `/admin/*`, and so on). Their 404s travel through the defect
// channel as benign control flow, not real errors, so we skip them here to keep
// scanner noise from drowning out genuine defects in error tracking.

// An unmatched route surfaces as an Effect `HttpServerResponse` with status 404.
if (HttpServerResponse.isHttpServerResponse(defect) && defect.status === 404) {
return Effect.void;
}

// A 404 raised as a thrown response (e.g. Better Auth's `onAPIError: { throw: true }`)
// is captured as `"Response returned status 404."`.
if (
typeof defect === "object" &&
defect !== null &&
"message" in defect &&
defect.message === "Response returned status 404."
) {
return Effect.void;
}

return Effect.gen(function* () {
const currentContext = yield* Effect.context();
const session = Context.getOption(currentContext, Session.Service);
Expand Down
Loading