Enforce default at validation error #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Hojland wants to merge 10 commits into levii:master from Hojland:master

Hojland commented Oct 12, 2021 •

edited

Loading

I had a usecase where I wanted to be able to just enforce the default types, whenever another type was given to the class.

The change is a flag to the main validator classes, where if set to True will set the value to the default value if the validation fails


          patch: handling typeerrors using default value using enforce flag

20530e5

ghost reviewed

View reviewed changes

dataclass_type_validator/__init__.py

    
                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None

                                     for t in expected_type.__args__)

                  if str(expected_type).startswith("typing.Union"):

                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None for t in expected_type.__args__)

ghost Oct 12, 2021

[Flake8] line too long (124 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.


          patch: handling default factory defaults in enforce

24990d9

ghost reviewed

View reviewed changes

dataclass_type_validator/__init__.py Outdated

    
                      if err is not None:

                          errors[field_name] = err

                          if enforce:

                              val = field.default if not isinstance(field.default, dataclasses._MISSING_TYPE) else field.default_factory()

ghost Oct 13, 2021

[Flake8] line too long (124 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.

GA-Ramlov and others added 2 commits

November 10, 2021 17:34


          Update of dataclass_type_validator

93f69cf

Added functionality to work with pydantic BaseModel


          Merge pull request #1 from GA-Ramlov/patch-1

a78fdb0

Update of dataclass_type_validator

ghost reviewed

View reviewed changes

dataclass_type_validator/__init__.py

    
                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None

                                     for t in expected_type.__args__)

                  if str(expected_type).startswith("typing.Union"):

                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None for t in expected_type.__args__)

ghost Nov 11, 2021

[Flake8] line too long (124 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                      if err is not None:

                          errors[field_name] = err

                          if enforce:

                              val = field.default if not isinstance(val, (dataclasses._MISSING_TYPE, type(None)) else field.default_factory()

ghost Nov 11, 2021

[Flake8] line too long (127 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.


          feat: pydantic typechecking

b16913b

ghost reviewed

View reviewed changes

dataclass_type_validator/__init__.py Outdated

    
                  return cls

              if __name__ == "__main__":

                  #@dataclasses.dataclass

ghost Nov 11, 2021

[Flake8] block comment should start with '# ' (view)

Rule
`E265`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
              if __name__ == "__main__":

                  #@dataclasses.dataclass

                  #class TestClass:

ghost Nov 11, 2021

[Flake8] block comment should start with '# ' (view)

Rule
`E265`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                  #    k: str = "key"

                  #    v: float = 1.2

                  #test_class = TestClass(k=1.2, v="key")

ghost Nov 11, 2021

[Flake8] block comment should start with '# ' (view)

Rule
`E265`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                  #test_class = TestClass(k=1.2, v="key")

                  #@dataclasses.dataclass

ghost Nov 11, 2021

[Flake8] block comment should start with '# ' (view)

Rule
`E265`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                  #test_class = TestClass(k=1.2, v="key")

                  #@dataclasses.dataclass

                  #class TestClass:

ghost Nov 11, 2021

[Flake8] block comment should start with '# ' (view)

Rule
`E265`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py

    
                  #test_class = TestClass(k=1.2, v="key")

                  from pydantic import root_validator

                  class TestClass(BaseModel):

ghost Nov 11, 2021

[Flake8] expected 1 blank line, found 0 (view)

Rule
`E301`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                      cls_name = f"{cls.__module__}.{cls.__name__}" if cls.__module__ != "__main__" else cls.__name__

                      logger.warning(f"Dataclass type validation failed, types are enforced. {cls_name} errors={repr(errors)})")

              def pydantic_type_validator(cls, values: dict, strict: bool = False, enforce: bool = False):

ghost Nov 11, 2021

[Flake8] expected 2 blank lines, found 1 (view)

Rule
`E302`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py

    
                  return cls

              if __name__ == "__main__":

ghost Nov 11, 2021

[Flake8] expected 2 blank lines after class or function definition, found 1 (view)

Rule
`E305`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                      if err is not None:

                          errors[field_name] = err

                          if enforce:

                              val = field.default if not isinstance(field.default, (dataclasses._MISSING_TYPE, type(None))) else field.default_factory()

ghost Nov 11, 2021

[Flake8] line too long (138 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py Outdated

    
                  setattr(test_class, "v", "key")

                  print(test_class)

                  test_class.validate_class()

                  print(test_class)

ghost Nov 11, 2021

[Flake8] no newline at end of file (view)

Rule
`W292`

You can close this issue if no need to fix it. Learn more.


          fix: fix error when there is no input, but there is a default

5155f90

ghost reviewed

View reviewed changes

dataclass_type_validator/__init__.py

    
                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None

                                     for t in expected_type.__args__)

                  if str(expected_type).startswith("typing.Union"):

                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None for t in expected_type.__args__)

ghost Nov 29, 2021

[Flake8] line too long (124 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.

Hojland added 3 commits

November 29, 2021 16:18


          fix: setting correct type when input is custom class

8c3cef0


          feat: better pydantic validation using pydantic's own validate_model

1f22e71


          patch: removed redundant errors

66a3a8e

ghost reviewed

View reviewed changes

dataclass_type_validator/__init__.py

    
                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None

                                     for t in expected_type.__args__)

                  if str(expected_type).startswith("typing.Union"):

                      is_valid = any(_validate_types(expected_type=t, value=value, strict=strict) is None for t in expected_type.__args__)

ghost Nov 30, 2021

[Flake8] line too long (124 > 120 characters) (view)

Rule
`E501`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py

    
              def pydantic_type_validator(

                  model: Type[BaseModel], input_data: "DictStrAny", cls: "ModelOrDc" = None, enforce: bool = False

ghost Nov 30, 2021

[Flake8] undefined name 'DictStrAny' (view)

Rule
`F821`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py

    
              def pydantic_type_validator(

                  model: Type[BaseModel], input_data: "DictStrAny", cls: "ModelOrDc" = None, enforce: bool = False

ghost Nov 30, 2021

[Flake8] undefined name 'ModelOrDc' (view)

Rule
`F821`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py

    
              def pydantic_type_validator(

                  model: Type[BaseModel], input_data: "DictStrAny", cls: "ModelOrDc" = None, enforce: bool = False

              ) -> Tuple["DictStrAny", "SetStr", Optional[ValidationError]]:

ghost Nov 30, 2021

[Flake8] undefined name 'DictStrAny' (view)

Rule
`F821`

You can close this issue if no need to fix it. Learn more.

dataclass_type_validator/__init__.py

    
              def pydantic_type_validator(

                  model: Type[BaseModel], input_data: "DictStrAny", cls: "ModelOrDc" = None, enforce: bool = False

              ) -> Tuple["DictStrAny", "SetStr", Optional[ValidationError]]:

ghost Nov 30, 2021

[Flake8] undefined name 'SetStr' (view)

Rule
`F821`

You can close this issue if no need to fix it. Learn more.


          chore: bump

752ebc8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet