-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Elixir 1.18 #849
base: main
Are you sure you want to change the base?
Support Elixir 1.18 #849
Conversation
I keep seeing errors pop up, seemingly due to some issue with elixir_sense. Logs here |
@Moosieus Updated elixir_sense. That should take care of the error you're seeing (I was told it's benign, but yes, it's gross). |
That about sums up my experience. I've pulled the update, gonna work with it and see if anything else crops up. |
That seems to have done the trick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been using without issues, and the code looks good on review.
Is this kinda dead in the water? I know they're working on the unified LS - but is lexical still receiving updates in the meantime? |
I was waiting this pr to be merged as well, but then I installed manually using the 1.18 branch. I went back to next-ls for a while, but this is much faster on my setup. Cloning, switching to It works with my lazyvim/neovim setup: https://github.com/rdlu/dotfiles/blob/main/lazyvim/.config/nvim/lua/plugins/elixir.lua Also with zed editor I just symlinked to |
hmm I tried your config (I'm also using lazyvim so there wasn't really much difference except the build path) and built from latest commit on this branch, but it wouldn't run so seems some issues still. FWIW, I made sure to build on the same version of elixir/otp as I ran in the test repo. elixir 1.18.2 and otp 27.2.2 My lexical.log attached. |
By looking at you log you are using Windows, am I right? I'm not sure if I can help, I'm exclusively using Linux since eons ago (sometimes macos) But sometimes my neovim or zed editor get stuck, the suggestions stop appearing, My workaround to avoid this is whenever there are major changes to versions I prefer to clean everything that was built. I have this in my
|
No worries, was just posted in case this helps a maintainer, I'm more than used to elixir tools being broken and unusable, so just check in from time to time to see if they work in neovim (spoiler, they never do). I'm running macos, super standard nothing special, default everything with neovim/lazynvim. Nothing ever works, its cool ✌🏼 |
Support 1.18.
Test failures were due to old versions of beam files hanging around. This quiets warnings and all tests pass locally.
Fixes #846