Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to verify that environment variables don't leak into module file of subsequent installations #5

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/framework/sandbox/easybuild/easyblocks/t/toy.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,10 @@ def make_module_extra(self):
txt = super(EB_toy, self).make_module_extra()
txt += self.module_generator.set_environment('TOY', os.getenv('TOY', '<TOY_env_var_not_defined>'))
return txt

def make_module_req_guess(self):
"""Extra paths for environment variables to consider"""
guesses = super(EB_toy, self).make_module_req_guess()
if self.name == 'toy':
guesses['CPATH'].append('toy-headers')
return guesses
36 changes: 36 additions & 0 deletions test/framework/toy_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -4302,6 +4302,42 @@ def test_toy_python(self):
self.assertTrue(ebpythonprefixes_regex.search(toy_mod_txt),
f"Pattern '{ebpythonprefixes_regex.pattern}' found in: {toy_mod_txt}")

def test_toy_multiple_ecs_module(self):
"""
Verify whether module file is correct when multiple easyconfigs are being installed.
"""
test_ecs = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'easyconfigs', 'test_ecs')
toy_ec = os.path.join(test_ecs, 't', 'toy', 'toy-0.0.eb')

# modify 'toy' easyconfig so toy-headers subdirectory is created,
# which is taken into account by EB_toy easyblock for $CPATH
test_toy_ec = os.path.join(self.test_prefix, 'test-toy.eb')
toy_ec_txt = read_file(toy_ec)
toy_ec_txt += "\npostinstallcmds += ['mkdir %(installdir)s/toy-headers']"
toy_ec_txt += "\npostinstallcmds += ['touch %(installdir)s/toy-headers/toy.h']"
write_file(test_toy_ec, toy_ec_txt)

# modify 'toy-app' easyconfig so toy-headers subdirectory is created,
# which is consider by EB_toy easyblock for $CPATH,
# but should *not* be actually used because software name is not 'toy'
toy_app_ec = os.path.join(test_ecs, 't', 'toy-app', 'toy-app-0.0.eb')
test_toy_app_ec = os.path.join(self.test_prefix, 'test-toy-app.eb')
toy_ec_txt = read_file(toy_app_ec)
toy_ec_txt += "\npostinstallcmds += ['mkdir %(installdir)s/toy-headers']"
toy_ec_txt += "\npostinstallcmds += ['touch %(installdir)s/toy-headers/toy.h']"
write_file(test_toy_app_ec, toy_ec_txt)

self.run_test_toy_build_with_output(ec_file=test_toy_ec, extra_args=[test_toy_app_ec])

toy_modtxt = read_file(os.path.join(self.test_installpath, 'modules', 'all', 'toy', '0.0.lua'))
regex = re.compile('prepend[-_]path.*CPATH.*toy-headers', re.M)
self.assertTrue(regex.search(toy_modtxt),
f"Pattern '{regex.pattern}' should be found in: {toy_modtxt}")

toy_app_modtxt = read_file(os.path.join(self.test_installpath, 'modules', 'all', 'toy-app', '0.0.lua'))
self.assertFalse(regex.search(toy_app_modtxt),
f"Pattern '{regex.pattern}' should *not* be found in: {toy_app_modtxt}")


def suite():
""" return all the tests in this file """
Expand Down
Loading