Conversation
This was referenced May 13, 2024
Collaborator
|
Sorry for the delay! Following some recent changes (splitting the runtime into many CMake modules), the libraries need to be added to Setting up a compilation test should be doable, the main steps are:
I'm not familiar with how the automated tests are set up, but I imagine this could be accomplished by copying the Ubuntu tests and adding a few lines. |
sberkun
approved these changes
May 25, 2024
Collaborator
|
Looks like this change is also included in #2178, so I think this can be safely be closed. |
Member
Member
|
Given the lack of response I'm assuming it's safe to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RPi pico support needs updates to support v0.7. In this PR I make a few minor changes needed. I have not setup the pico toolchain locally so haven't tested it. See: #2282 Maybe @sberkun can follow up on it?
Would be great with a simple CI test that at least builds a hello world to avoid this in the future. Do you have any estimate of how hard that would be Samuel?