Fix for the wrong return value of lf_check_deadline

[byeonggiljun]

This PR fixes an error that lf_check_deadline() with the argument invoke_deadline_handler of false returns false even if the reaction has passed the deadline.

[hokeun]

Thanks for spotting and fixing this error!

[hokeun]

There is one Python test failing, "Failed: src/DeadlineAnytime.lf in 0.04 seconds" which could be caused by this change, but there is a chance that the error is in the test rather than this PR's change.

[byeonggiljun]

The error message is ERROR: check_deadline() returned true when there is no deadline.

I think this is the issue caused by this PR's change.
The problem is that check_deadline() returns true inside the reaction without any deadline now. This is because the if statement below is true if there is no deadline (it seems like the default deadline value is 0).

reactor-c/lib/schedule.c

Line 84 in 90fabf9

if (lf_time_physical() > (lf_time_logical(((self_base_t*)self)->environment) + reaction->deadline)) {

I think one solution is as follows, assuming that reaction->deadline_violation_handler is NULL if the reaction has no deadline.

  if (lf_time_physical() > (lf_time_logical(((self_base_t*)self)->environment) + reaction->deadline)) {
    if (reaction->deadline_violation_handler != NULL) {
      if (invoke_deadline_handler) {
        reaction->deadline_violation_handler(self);
      }
      return true;
    }
  }

[Copilot]

Pull request overview

Fixes lf_check_deadline() so it reports whether the currently executing reaction has missed its deadline even when invoke_deadline_handler is false.

Changes:

• Refactors lf_check_deadline() to separate “deadline passed” from optional handler invocation.
• Adjusts control flow so the function can return true even when the handler is not invoked.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.