-
Notifications
You must be signed in to change notification settings - Fork 38
PRIMARY KEY only for table, FOREIGN TABLE not support it #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hello @lfittl, why you not accept my pull request? |
@ermolaev Sorry, been very busy. Thanks for your contribution! It seems that this wouldn't work if the id column was not listed first in the table - is there a way we can implement this where it allows other columns to be listed in between? |
Yes you are right! |
@ermolaev Sorry for not getting back about this - could you re-base this PR? |
@ermolaev Your changes look good, could you rebase on top of current master? |
@ermolaev @olleolleolle Hello. It's been a long time, but I'm wondering if there's still interest in getting this functionality into the gem? If so, please confirm that, and please rebase the changes on the latest version of the master branch. If you could expand on the use case a bit, and ideally include some sample schema that shows a positive and negative example, possibly as documentation, that would help understand the purpose and how to verify this functionality while avoiding a regression. If there's no response here after a month, then we'll likely close this out. Thanks. |
I think this PR may be closed, now I support fork https://github.com/corp-gp/activerecord-clean-db-structure this fork fixed some problems with running migration (via web interface) and added conditions for working with timescaledb, fdw, fillfactor option |
No description provided.