Skip to content

PRIMARY KEY only for table, FOREIGN TABLE not support it #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ermolaev
Copy link

@ermolaev ermolaev commented May 2, 2017

No description provided.

@ermolaev
Copy link
Author

hello @lfittl, why you not accept my pull request?

@lfittl
Copy link
Owner

lfittl commented May 11, 2017

@ermolaev Sorry, been very busy. Thanks for your contribution!

It seems that this wouldn't work if the id column was not listed first in the table - is there a way we can implement this where it allows other columns to be listed in between?

@ermolaev
Copy link
Author

Yes you are right!
I fixed it.

@lfittl
Copy link
Owner

lfittl commented Jun 13, 2017

@ermolaev Sorry for not getting back about this - could you re-base this PR?

@olleolleolle
Copy link

@ermolaev Your changes look good, could you rebase on top of current master?

@andyatkinson
Copy link
Collaborator

andyatkinson commented Aug 29, 2024

@ermolaev @olleolleolle Hello. It's been a long time, but I'm wondering if there's still interest in getting this functionality into the gem?

If so, please confirm that, and please rebase the changes on the latest version of the master branch.

If you could expand on the use case a bit, and ideally include some sample schema that shows a positive and negative example, possibly as documentation, that would help understand the purpose and how to verify this functionality while avoiding a regression.

If there's no response here after a month, then we'll likely close this out. Thanks.

@ermolaev
Copy link
Author

I think this PR may be closed, now I support fork https://github.com/corp-gp/activerecord-clean-db-structure

this fork fixed some problems with running migration (via web interface) and added conditions for working with timescaledb, fdw, fillfactor option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants