Add the ability to insert deferrable constraints after the table body #57
Conversation
|
|
||
| if options[:indexes_after_tables] == true | ||
| # Extract indexes, remove comments and place them just after the respective tables | ||
| if options[:meta_tables_after_main] == true |
There was a problem hiding this comment.
For backwards comparability it would be better to check both the new and old setting:
if options[:indexes_after_tables] || options[:meta_tables_after_main]
kravcneger
force-pushed
the
feature-deferrable-constraints-after-main
branch
2 times, most recently
from
041591a to
e5d7621
Compare
|
|
||
| if options[:indexes_after_tables] == true | ||
| # Extract indexes, remove comments and place them just after the respective tables | ||
| if options[:indexes_after_tables] || options[:meta_tables_after_main] |
There was a problem hiding this comment.
Do you want to leave a comment to indicate options[:indexes_after_tables] is the old option and is deprecated, and maybe specify a version where it will be removed? We could also add the deprecation announcement into the release notes.
|
@kravcneger Thanks for your patience on this pull request! I just discussed this with @seanlinsley and colleagues, and we had one more change we'd like to make here before merging: The term If you agree with that, happy to have you make the change, or we can also edit the PR and then approve and merge if you prefer. |
kravcneger
force-pushed
the
feature-deferrable-constraints-after-main
branch
2 times, most recently
from
78ae86b to
b1e85c3
Compare
kravcneger
force-pushed
the
feature-deferrable-constraints-after-main
branch
from
b1e85c3 to
b77ea5a
Compare
|
@kravcneger Thanks for updating this, and appreciate your patience in getting this merged! |
4 participants
Guys, at least one type of constraint can be placed after the table definition, just like indexes. It also improves the readability of the schema.