Support rails.7.2 & update CI to run on Ruby 3 x Rails 6 & 7 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mohammed-io
commented
Oct 11, 2024
* chore: add appraisal * update CI to run on ruby/rails matrix * no need to have test lockfiles in repo * fix typo and cleanup * continue on error * no need for dark magic rails test? * Fixed rubocop --------- Co-authored-by: Mohammed Abdulkareem <[email protected]> Co-authored-by: Mohammed Abdulkareem <[email protected]>
swiknaba
changed the title
swiknaba
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support Rails 7.2; replaces #1
Motivation
Test plan
Rollout/monitoring/revert plan