Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map based point neighbor ghosting functor #1887

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

friedmud
Copy link
Member

@friedmud friedmud commented Oct 9, 2018

Adds a superfast point neighbor ghosting functor that uses the nodes_to_elem_map. Apparently it does have some limitations with respect to some element types and refinement (see: #1859 (comment) ) - but I think it should still be useful in 99% of cases.

@friedmud
Copy link
Member Author

friedmud commented Oct 9, 2018

Damn - I messed up something with metaphysicl. Any ideas @roystgnr and @lindsayad ?

@@ -38,10 +38,10 @@
#define NC_VERSION "4.4.1.1"

#define NC_HAS_NC2 1 /*!< API version 2 support. */
#define NC_HAS_NC4 1 /*!< API version 4 support. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file's changes look like a different-autotools-version false positive?

@@ -204,6 +205,54 @@ BUILT_SOURCES = \
unv_io.h \
vtk_io.h \
xdr_io.h \
compare_types.h \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how did this happen? You don't actually have these files in include/ anywhere, right? They're all in contrib?

@roystgnr
Copy link
Member

It looks as if somehow you had metaphysicl headers in include/*/ somewhere before running include/libmesh/rebuild_makefile.sh - could that possibly be the case? I just tried running that myself but it was a no-op (as it should be when I haven't added any headers). The script is hand-crafted but find .. -name '*.h' etc. doesn't leave much ambiguity.

@permcody
Copy link
Member

permcody commented Oct 10, 2018 via email

@friedmud
Copy link
Member Author

Yep - I had to basically copy all of the metaphysicl headers into include/metaphysicl to make my in-tree build work. I guess I then ran the scripts and accidentally added junk I didn't mean to add. Let me strip out all of that crap and re-push.

@friedmud friedmud force-pushed the map_point_neighbor_coupling branch from 00e6027 to 48922a1 Compare October 10, 2018 17:17
@friedmud
Copy link
Member Author

Don't merge this yet. I want to do some more testing of it first....

@jwpeterson
Copy link
Member

This PR has been marked "do not merge" since we are no longer accepting PRs into the master branch. All new PRs should be made on the devel branch instead. Once this PR's target branch has been updated to devel, the "do not merge" label will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants