-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map based point neighbor ghosting functor #1887
base: master
Are you sure you want to change the base?
Conversation
Damn - I messed up something with metaphysicl. Any ideas @roystgnr and @lindsayad ? |
@@ -38,10 +38,10 @@ | |||
#define NC_VERSION "4.4.1.1" | |||
|
|||
#define NC_HAS_NC2 1 /*!< API version 2 support. */ | |||
#define NC_HAS_NC4 1 /*!< API version 4 support. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file's changes look like a different-autotools-version false positive?
include/libmesh/Makefile.am
Outdated
@@ -204,6 +205,54 @@ BUILT_SOURCES = \ | |||
unv_io.h \ | |||
vtk_io.h \ | |||
xdr_io.h \ | |||
compare_types.h \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how did this happen? You don't actually have these files in include/ anywhere, right? They're all in contrib?
It looks as if somehow you had metaphysicl headers in include/*/ somewhere before running include/libmesh/rebuild_makefile.sh - could that possibly be the case? I just tried running that myself but it was a no-op (as it should be when I haven't added any headers). The script is hand-crafted but |
Custom in-tree build script is getting in the way!
…On Tue, Oct 9, 2018 at 8:40 PM roystgnr ***@***.***> wrote:
It looks as if somehow you had metaphysicl headers in include/*/ somewhere
before running include/libmesh/rebuild_makefile.sh - could that possibly be
the case? I just tried running that myself but it was a no-op (as it should
be when I haven't added any headers). The script is hand-crafted but find
.. -name '*.h' etc. doesn't leave much ambiguity.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1887 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC5XIPuATdigTLAJBhYTwtrlCu9SDO2yks5ujV4NgaJpZM4XUVBH>
.
|
Yep - I had to basically copy all of the metaphysicl headers into |
00e6027
to
48922a1
Compare
Don't merge this yet. I want to do some more testing of it first.... |
This PR has been marked "do not merge" since we are no longer accepting PRs into the |
Adds a superfast point neighbor ghosting functor that uses the nodes_to_elem_map. Apparently it does have some limitations with respect to some element types and refinement (see: #1859 (comment) ) - but I think it should still be useful in 99% of cases.