Skip to content

Ignore clippy lint warning for derive default #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Ignore clippy lint warning for derive default #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libbpf-cargo/src/btf/btf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,9 @@ impl Btf {

// write an impl Default for this enum
if !t.values.is_empty() {
// TODO: remove #[allow(clippy::derivable_impls)]
// once minimum rust at 1.62+
writeln!(def, r#"#[allow(clippy::derivable_impls)]"#)?;
writeln!(def, r#"impl Default for {name} {{"#, name = t.name)?;
writeln!(def, r#" fn default() -> Self {{"#)?;
writeln!(
Expand Down
2 changes: 2 additions & 0 deletions libbpf-cargo/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,6 +1480,7 @@ pub enum Foo {
One = 1,
seven = 7,
}
#[allow(clippy::derivable_impls)]
impl Default for Foo {
fn default() -> Self {
Foo::Zero
Expand Down Expand Up @@ -2075,6 +2076,7 @@ pub struct Foo {
pub enum __anon_1 {
FOO = 1,
}
#[allow(clippy::derivable_impls)]
impl Default for __anon_1 {
fn default() -> Self {
__anon_1::FOO
Expand Down