-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add wheel build for macOS #88
base: master
Are you sure you want to change the base?
Conversation
@sdelafond any comments on this PR? Ignore the workflow |
I typically don't review "draft" PRs, only finalized ones. I had a quick look at it just now since you prodded me, and the |
Ok, since no comments about the contents of the changes, or way of doing things, rebased and squashed commits. |
I said earlier "the ${{ matrix.os }} direction looks globally correct, but I'll probably want to see the whole picture without the linux builds disabled among other things".
Now that you've cleaned up and finalized your approach, the resulting
That can all be improved later. So with this we have wheels built for MacOS, but not corresponding CI checks in |
I agree it's a bit nasty having platform ifs around each step, but wanted to get it out of the door. I'd do the refactoring in a separate PR. I was thinking maybe could add extra step and add i did it this way right now to have all wheels collected to single artifact download, so it could upload to github release, but since you never wanted the artifacts upload to release, could drop the wheels collecting job, wheels would be still uploaded to artifacts, but from multiple jobs (multiple artifacts). I'll be checking how to add matrix to regular ci (python.yml), no promises when. but if you beat me to it, ping it here when starting working on it. |
I understand.
You mean upload to pypi?
I don't expect it would look different when a new release is created from a tag on GH, but this will be worth testing.
Will do. |
you said you didn't want github action upload to pypi. so I thought attaching the wheels to github release, so you could download and upload manually. but if you don't use that either, that would simplify some things. i.e drop the wheels collecting under single artitact. |
I don't want to upload to pypi from GH, but I download, check and use the wheels built on GH to create the pypi release. |
Adds default wheel build:
cp313-cp313-macosx_10_13_universal2.whl
.Using build matrix on that platform can be done later if needed.
Artifact download URL: https://github.com/libfuse/python-fuse/actions/runs/12575994383/artifacts/2377153480
Refs