Skip to content

Add fast paths for FlipVertical, FlipHorizontal, and Rotate180 orientations #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veluca93 merged 2 commits into from
Jan 5, 2026
Merged

Add fast paths for FlipVertical, FlipHorizontal, and Rotate180 orientations #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c630d
Add fast paths for all 8 orientation variants in save stage
hjanuschka Dec 22, 2025
f6de453
Reduce scope to only add FlipVertical fast path
hjanuschka Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions jxl/src/render/low_memory_pipeline/save/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,17 @@ impl SaveStage {
relative_y,
self.data_format,
),
Orientation::FlipVertical => identity::store(
data,
frame_y,
save_start.0..save_end.0,
buf,
save_size.1 - 1 - relative_y,
self.data_format,
),
_ => 0,
};

// TODO(veluca): this is very slow, implement more fast paths.

macro_rules! write_pixel {
($px: expr, $endianness: expr, $y: expr, $x: expr) => {
let px = $px;
Expand Down
Loading