fix: use extra channel's own bit_depth for modular-to-f32 conversion #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanuschka
force-pushed
the
fix-extra-channel-bitdepth
branch
from
57a9a80 to
15e2dbb
Compare
Benchmark @ 373ab08Comparing: 3badb391 (Base) vs fcd3d4cf (PR)
|
veluca93
reviewed
Jan 20, 2026
veluca93
approved these changes
Jan 20, 2026
Co-authored-by: Lilith River <[email protected]>
Tests removed: - test_extra_channel_bit_depth (just tests struct field storage) - test_extra_channel_float_bit_depth (equivalent to testing BitDepth directly) - test_wrong_bit_depth_produces_wrong_conversion (tests math in isolation) - test_modular_to_f32_bit_depth_matters (same issue) Kept the modular_to_f32 consistency tests as they actually exercise the stage.
veluca93
force-pushed
the
fix-extra-channel-bitdepth
branch
from
6751dda to
373ab08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Takes over #604 from @lilith who is unable to continue.
bit_depthinstead of the image's globalmetadata.bit_depthfor modular-to-f32 conversionbit_depth()getter toExtraChannelInfoPreviously, an 8-bit extra channel decoded with a 16-bit image would have its max value (255) incorrectly mapped to ~0.00389 instead of 1.0.
Closes #604
Co-authored-by: Lilith River [email protected]