Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Andrew and Hector to shipyard team #275

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 20, 2025

Summary

Why do you need this?

To help with bugfix releases, if we need them in future.

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@lidel lidel requested review from a team as code owners February 20, 2025 20:05
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User cewood:
  - will gain maintain permission to go-libp2p-kad-dht
User gammazero:
  - will have the permission to go-libp2p change from push to maintain
  - will have the permission to go-libp2p-kad-dht change from push to maintain
  - will gain maintain permission to js-libp2p
User hsanjuan:
  - will have the permission to go-libp2p change from push to maintain
  - will have the permission to go-libp2p-kad-dht change from push to maintain
  - will gain maintain permission to js-libp2p
User sgtpooki:
  - will gain maintain permission to go-libp2p-kad-dht

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_team_membership.this["kubo maintainers:gammazero"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "7610265"
      + username = "gammazero"
    }

  # github_team_membership.this["kubo maintainers:guillaumemichel"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "7610265"
      + username = "guillaumemichel"
    }

  # github_team_membership.this["kubo maintainers:hsanjuan"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "7610265"
      + username = "hsanjuan"
    }

  # github_team_membership.this["kubo maintainers:jorropo"] will be destroyed
  # (because key ["kubo maintainers:jorropo"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"efc5026e5d0dbeadc263891be016ce5751cb39f453937a41621b8f32c247f8a3\"" -> null
      - id       = "7610265:Jorropo" -> null
      - role     = "member" -> null
      - team_id  = "7610265" -> null
      - username = "Jorropo" -> null
    }

  # github_team_membership.this["shipyard:gammazero"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "10765583"
      + username = "gammazero"
    }

  # github_team_membership.this["shipyard:hsanjuan"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "10765583"
      + username = "hsanjuan"
    }

  # github_team_repository.this["shipyard:go-libp2p-kad-dht"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "go-libp2p-kad-dht"
      + team_id    = "10765583"
    }

Plan: 6 to add, 0 to change, 1 to destroy.

@lidel
Copy link
Member Author

lidel commented Feb 20, 2025

@galargh if no concerns, mind merging?

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galargh galargh merged commit cd7ff6c into libp2p:master Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants