Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.0.0 #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Release v5.0.0 #125

wants to merge 1 commit into from

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Feb 7, 2025

Incrementing the major version since the returned errors are changed and users need to update err == ErrStreamReset checks to errors.Is(err, ErrStreamReset)

@sukunrt sukunrt requested a review from MarcoPolo February 7, 2025 13:59
Copy link

github-actions bot commented Feb 7, 2025

Suggested version: 5.0.0

Comparing to: v4.0.2 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# github.com/libp2p/go-yamux/v4
## incompatible changes
ErrRemoteGoAway: changed from *Error to *GoAwayError
ErrSessionShutdown: changed from *Error to *GoAwayError
## compatible changes
(*Session).CloseWithError: added
(*Stream).ResetWithError: added
GoAwayError: added
StreamError: added

# summary
Cannot suggest a release version.
Incompatible changes were detected.

gocompat says:

HEAD is now at c60349b Release v4.0.2 (#124)
Previous HEAD position was c60349b Release v4.0.2 (#124)
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants