feat(types): Support custom events on PubSub and PeerStreams #3078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysonclugg
force-pushed
the
feature/custom-peerstream-events
branch
from
edb5f91 to
59eabb0
Compare
|
@tysonclugg We're thinking of removing pubsub from the js-libp2p monorepo (in the future perhaps as a part of v3) and so, this PR is better served to be made against https://github.com/ChainSafe/js-libp2p-gossipsub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat(types): Support custom events on PubSub and PeerStreams
Description
Allow implementations of PubSub and PeerStreams to maintain type safety when using custom events.
Notes & open questions
Given these changes don't affect functional code paths and that there's no clear direction on how typescript only changes should be tested in js-libp2p, I've not added any tests.
Change checklist