Skip to content

deps: bump node-datachannel from 0.29.0 to 0.30.0 #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deps: bump node-datachannel from 0.29.0 to 0.30.0 #3325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f9d828
deps: bump node-datachannel from 0.29.0 to 0.30.0
dependabot[bot] Oct 2, 2025
5f324e2
chore: remove ts-expect-errors
achingbrain Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/transport-webrtc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"it-stream-types": "^2.0.2",
"main-event": "^1.0.1",
"multiformats": "^13.4.0",
"node-datachannel": "^0.29.0",
"node-datachannel": "^0.30.0",
"p-defer": "^4.0.1",
"p-event": "^7.0.0",
"p-timeout": "^7.0.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/transport-webrtc/src/private-to-private/initiate-connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export async function initiateConnection ({ rtcConfiguration, dataChannel, signa
})

const muxerFactory = new DataChannelMuxerFactory({
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
peerConnection,
dataChannelOptions: dataChannel
})
Expand Down Expand Up @@ -209,7 +208,6 @@ export async function initiateConnection ({ rtcConfiguration, dataChannel, signa

return {
remoteAddress: ma,
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
peerConnection,
muxerFactory
}
Expand Down
3 changes: 0 additions & 3 deletions packages/transport-webrtc/src/private-to-private/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ export class WebRTCTransport implements Transport<WebRTCDialEvents>, Startable {
}
})
const muxerFactory = new DataChannelMuxerFactory({
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
peerConnection,
dataChannelOptions: this.init.dataChannel
})
Expand All @@ -229,7 +228,6 @@ export class WebRTCTransport implements Transport<WebRTCDialEvents>, Startable {
})

const webRTCConn = toMultiaddrConnection({
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
peerConnection,
remoteAddr: remoteAddress,
metrics: this.metrics?.listenerEvents,
Expand All @@ -246,7 +244,6 @@ export class WebRTCTransport implements Transport<WebRTCDialEvents>, Startable {
})

// close the connection on shut down
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
this._closeOnShutdown(peerConnection, webRTCConn)
} catch (err: any) {
this.log.error('incoming signaling error - %e', err)
Expand Down
1 change: 0 additions & 1 deletion packages/transport-webrtc/src/private-to-public/utils/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export async function connect (peerConnection: RTCPeerConnection | DirectRTCPeer
// Creating the connection before completion of the noise
// handshake ensures that the stream opening callback is set up
const maConn = toMultiaddrConnection({
// @ts-expect-error types are broken
peerConnection,
remoteAddr: options.remoteAddr,
metrics: options.events,
Expand Down
1 change: 0 additions & 1 deletion packages/transport-webrtc/src/private-to-public/utils/get-rtcpeerconnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ export async function createDialerRTCPeerConnection (role: 'client' | 'server',
})

const muxerFactory = new DataChannelMuxerFactory({
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
peerConnection,
metrics: options.events,
dataChannelOptions: options.dataChannel
Expand Down
1 change: 0 additions & 1 deletion packages/transport-webrtc/test/maconn.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ describe('Multiaddr Connection', () => {
reset: () => {}
})
const maConn = toMultiaddrConnection({
// @ts-expect-error https://github.com/murat-dogan/node-datachannel/pull/370
peerConnection,
remoteAddr,
metrics,
Expand Down
Loading