Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interop): update ping to conform to the new interop spec #3423

Merged
merged 12 commits into from
Feb 2, 2023

Conversation

jxs
Copy link
Member

@jxs jxs commented Feb 1, 2023

Description

Notes

Will switch the base to master when #3409 is merged (or anyone with editing permissions can do that)

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

.unwrap_or_else(|_| "10".into())
.parse::<usize>()?;
.parse::<u64>()?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed from usize to u64 because of Duration::from_secs

@thomaseizinger
Copy link
Contributor

Will switch the base to master when #3409 is merged (or anyone with editing permissions can do that)

GitHub will do it for you as soon as the branch gets deleted. They call it "automatic pull request retargeting" :)

Unfortunately, it doesn't quite work as well with squash-merging because Git doesn't always detect that the new commit is based on all the old ones it already has in its history.

Base automatically changed from tidy-up-interop-tests to master February 1, 2023 22:20
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2023

This pull request has merge conflicts. Could you please resolve them @jxs? 🙏

@jxs jxs force-pushed the update-rust-test-conform-new-spec branch from d8b07cf to 671fbcc Compare February 2, 2023 09:59
@jxs jxs added the send-it label Feb 2, 2023
@mergify mergify bot merged commit 53e477d into master Feb 2, 2023
@mergify mergify bot deleted the update-rust-test-conform-new-spec branch February 2, 2023 11:42
@jxs jxs removed the send-it label Feb 2, 2023
@jxs
Copy link
Member Author

jxs commented Feb 2, 2023

sometimes mergify takes hours, now it took one minute 😅 this will break the CI pipeline right @thomaseizinger?

UPDT: Yup it will libp2p/test-plans#121 hasn't yet been merged, sorry. Will submit a PR reverting this, or do you suggest waiting for libp2p/test-plans#121 Thomas? If so I can fix the conflicts on #3415 meanwhile, publish the image and submit a PR to test-plans.

UPDT #2:
There's also #3414 which needs a PR on https://github.com/libp2p/github-mgmt to rename the required test. So we could:

  1. Start there, rename the required test to "Run multidimensional interoperability tests"
  2. Merge feat(ci): use interop-tests action instead of workflow #3414
  3. Publish docker image with v0.50
  4. Add v0.50 imageid to Update Go & JS tests to conform to the multidim interop test spec. test-plans#121 and merge it

wdyt?

@thomaseizinger
Copy link
Contributor

sometimes mergify takes hours, now it took one minute sweat_smile

If the PR is green and up-to-date with the master branch, it will just merge it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants