Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quic): deprecate QUIC draft-29 version support #5786

Merged
merged 22 commits into from
Mar 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
538e2ff
feat: deprecated support_draft_29 field
tesol2y090 Dec 31, 2024
2a95c84
feat: update changelog
tesol2y090 Dec 31, 2024
5958303
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Dec 31, 2024
01552a7
feat: move changelog under 0.11.2
tesol2y090 Jan 1, 2025
5596502
chore: add allow deprecated on support_draft_29
tesol2y090 Jan 1, 2025
4cfd7eb
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Jan 3, 2025
d3e6a02
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Jan 28, 2025
b802f05
feat: use expect instead of allow
tesol2y090 Jan 28, 2025
2ac983c
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Feb 16, 2025
b304418
feat: move expect before function
tesol2y090 Feb 20, 2025
0fcf7b1
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Feb 20, 2025
c40abec
Merge branch 'master' into feat/quic/deprecated-draft-29
jxs Feb 20, 2025
a897691
feat: add allow deprecated
tesol2y090 Feb 21, 2025
56671ff
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Feb 21, 2025
81b87e9
Update transports/quic/src/config.rs
tesol2y090 Feb 21, 2025
84d810a
chore: bump version
tesol2y090 Feb 21, 2025
23c6036
fix: format
tesol2y090 Feb 21, 2025
8af3f27
fix: format
tesol2y090 Feb 21, 2025
f373aa2
chore: bump quic version
tesol2y090 Feb 22, 2025
364457f
chore: bump quic version
tesol2y090 Feb 22, 2025
f8050bf
Update transports/quic/CHANGELOG.md
tesol2y090 Mar 3, 2025
4d45dea
Merge branch 'master' into feat/quic/deprecated-draft-29
elenaf9 Mar 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ libp2p-perf = { version = "0.4.0", path = "protocols/perf" }
libp2p-ping = { version = "0.46.0", path = "protocols/ping" }
libp2p-plaintext = { version = "0.43.0", path = "transports/plaintext" }
libp2p-pnet = { version = "0.26.0", path = "transports/pnet" }
libp2p-quic = { version = "0.12.0", path = "transports/quic" }
libp2p-quic = { version = "0.12.1", path = "transports/quic" }
libp2p-relay = { version = "0.20.0", path = "protocols/relay" }
libp2p-rendezvous = { version = "0.16.0", path = "protocols/rendezvous" }
libp2p-request-response = { version = "0.28.1", path = "protocols/request-response" }
Expand Down
5 changes: 5 additions & 0 deletions transports/quic/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.12.1

- Deprecate `Config::support_draft_29`.
See [PR 5786](https://github.com/libp2p/rust-libp2p/pull/5786).

## 0.12.0

<!-- Update to libp2p-core v0.43.0 -->
Expand Down
2 changes: 1 addition & 1 deletion transports/quic/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "libp2p-quic"
version = "0.12.0"
version = "0.12.1"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"
rust-version = { workspace = true }
Expand Down
3 changes: 3 additions & 0 deletions transports/quic/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ pub struct Config {
/// If support for draft-29 is enabled servers support draft-29 and version 1 on all
/// QUIC listening addresses.
/// As client the version is chosen based on the remote's address.
#[deprecated(note = "QUIC draft versions are no longer supported")]
pub support_draft_29: bool,

/// TLS client config for the inner [`quinn::ClientConfig`].
Expand All @@ -72,6 +73,7 @@ pub struct Config {
mtu_discovery_config: Option<MtuDiscoveryConfig>,
}

#[expect(deprecated)]
impl Config {
/// Creates a new configuration object with default values.
pub fn new(keypair: &libp2p_identity::Keypair) -> Self {
Expand Down Expand Up @@ -122,6 +124,7 @@ pub(crate) struct QuinnConfig {
pub(crate) endpoint_config: quinn::EndpointConfig,
}

#[expect(deprecated)]
impl From<Config> for QuinnConfig {
fn from(config: Config) -> QuinnConfig {
let Config {
Expand Down
1 change: 1 addition & 0 deletions transports/quic/src/transport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ pub struct GenTransport<P: Provider> {
hole_punch_attempts: HashMap<SocketAddr, oneshot::Sender<Connecting>>,
}

#[expect(deprecated)]
impl<P: Provider> GenTransport<P> {
/// Create a new [`GenTransport`] with the given [`Config`].
pub fn new(config: Config) -> Self {
Expand Down
1 change: 1 addition & 0 deletions transports/quic/tests/smoke.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ fn concurrent_connections_and_streams_tokio() {
.quickcheck(prop::<quic::tokio::Provider> as fn(_, _) -> _);
}

#[expect(deprecated)]
#[cfg(feature = "tokio")]
#[tokio::test]
async fn draft_29_support() {
Expand Down
Loading