-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): ensure exactly one version bump #5804
base: master
Are you sure you want to change the base?
Conversation
(Doing a couple of test commits now to see if the CI catches wrong version bumps; will drop these commits later) |
2903528
to
5bccb0b
Compare
Ahh it seems like for some packages there hasn't been a git tag created last time they were released. E.g. Unfortunately this breaks the CI check, since the check is using git tags so see what the latest released version is. Unless there is an alternative idea to solve this I think the PR has to wait until the next release. |
Hi Elena, can't we create those tags? Should be easy to find which commits match the releases. |
a915f5d
to
37c24e7
Compare
So the CI (
It still feels a bit messy (well, it's bash....), but I wasn't able to come up with a better solution that checks all of the above criteria. Again, alternative suggestions are welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the CI (
scripts/ensure-version-bump-and-changelog.sh
) now checks that:
- there has been a version bump if there is a diff in the crate's code (already existed prior to this PR): see failing CI check for
libp2p-quic
- there is only a single version bump since the last release: see failing CI check for
libp2p-relay
- the patch version is back to 0 if there was a minor version bump: see failing CI check for
libp2p-server
andlibp2p-tls
It still feels a bit messy (well, it's bash....), but I wasn't able to come up with a better solution that checks all of the above criteria. Again, alternative suggestions are welcome.
Thanks Elena! I think thi is good enough for our needs, we should after probably focus on releasing from github action, so that we ensure that tags are created and it will also probably help us with the release hierarchy of the sub-crates
@@ -134,6 +134,7 @@ where | |||
/// | |||
/// Returns `0` when done, i.e. `source` having reached EOF, returns number of bytes sent otherwise, | |||
/// thus indicating progress. | |||
#[allow(clippy::assertions_on_constants)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for testing purposes right?
Description
Check in CI that the version of a crate has been bumped exactly once since the last release.
Based on discussion in #5781.
Notes & open questions
Current solution feels a bit hacky. Does anyone know a better way to solve this?
Change checklist