chore(request-response): migrate tests from async-std to tokio #5857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusc93
reviewed
Feb 10, 2025
Comment on lines
+15
to
+18
| cbor4ii = { version = "0.3.2", features = [ | ||
| "serde1", | ||
| "use_std", | ||
| ], optional = true } |
There was a problem hiding this comment.
Can we revert this and stick with the previous format?
elenaf9
previously approved these changes
Feb 11, 2025
|
Friendly ping @shiyasmohd :) |
|
Sorry for the delay @elenaf9 Will check this today. Thanks for reminding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating tests in protocols/request-response from async_std to tokio as per #4449
Notes & open questions
Change checklist