-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Report all transport errors in a dial attempt #5899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Left some suggestions. Can you bump the minor version to 0.44.0 since this is introducing a breaking change and 0.43 has already been released? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rose2221, this already looks good. Just some nits.
Co-authored-by: Darius Clark <[email protected]>
Thanks, @dariusc93 and @elenaf9, for the feedback! I've made the requested updates. Let me know if any further refinements are needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also bump the crate version in Cargo.toml
to 0.44 as well as in the workspace Cargo.toml
? :)
it's been done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good to me. Just a few nits about the test.
Co-authored-by: Elena Frank <[email protected]>
Co-authored-by: Elena Frank <[email protected]>
Co-authored-by: Elena Frank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow replies, my availability is a bit limited.
Few follow-up comments.
Co-authored-by: Elena Frank <[email protected]>
Co-authored-by: Elena Frank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the follow ups @rose2221.
Last nit, then only formatting and fixing the clippy beta lints is needed.
Co-authored-by: Elena Frank <[email protected]>
Co-authored-by: Elena Frank <[email protected]>
Description
Currently, when a DNS address resolves to multiple IPs, the transport dials each one, but only the last error is returned, while earlier errors are logged and lost. This causes issues like #5871, where users miss crucial failure details.
This PR aggregates all transport errors from failed dial attempts and returns them, similar to DialError::Transport at the swarm level.
Fixes
Fixes #5878
Fixes #5871
Change checklist