Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc): deprecated #[clap] attributes with #[arg] and #[command] #5932

Merged
merged 3 commits into from
Mar 14, 2025
Merged

fix(misc): deprecated #[clap] attributes with #[arg] and #[command] #5932

merged 3 commits into from
Mar 14, 2025

Conversation

lido333
Copy link
Contributor

@lido333 lido333 commented Mar 14, 2025 •
edited
Loading

Description

follow up: #5930

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

jxs
jxs reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Looks good to me! Can we add a changelog entry for rust-server and bump Cargo.toml to 0.12.7?
Thanks

@lido333
Copy link
Contributor Author

lido333 commented Mar 14, 2025

Hi, Looks good to me! Can we add a changelog entry for rust-server and bump Cargo.toml to 0.12.7? Thanks

done @jxs

jxs
jxs approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label Mar 14, 2025
@mergify mergify bot merged commit 88f7875 into libp2p:master Mar 14, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lido333 @jxs