Skip to content

fix(webrtc): turn down the webrtc log spam #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dhuseby
Copy link
Contributor

@dhuseby dhuseby commented Mar 31, 2025

Description

This PR changes a couple tracing::error!'s to tracing::warn!'s in the
webrtc code so that it won't spam the log so much. The error messages are still
available if you run your app with RUST_LOG=warn but if you run with the
default error level you will no longer get spammed.

Notes & open questions

Nope.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Signed-off-by: Dave Grantham [email protected]

Dave Grantham added 2 commits March 30, 2025 18:58
Signed-off-by: Dave Grantham <[email protected]>
Signed-off-by: Dave Grantham <[email protected]>
@dhuseby dhuseby changed the title turn down the webrtc log spam [fix]: turn down the webrtc log spam Mar 31, 2025
@dhuseby dhuseby changed the title [fix]: turn down the webrtc log spam fix(webrtc): turn down the webrtc log spam Mar 31, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dave, thanks for this, but I don't think it makes sense to turn down logging level just to avoid them not outputting as the default RUST_LOG level is error, these are in fact errors.
Specially as I think when the code reaches these errors the connection has reached an unrecoverable state right?

@elenaf9
Copy link
Contributor

elenaf9 commented Apr 3, 2025

@dhuseby if these errors occur very frequent in your logs then it might be an indication of bigger underlying issue. Could you provide some debug-level logs where this error appears?

The function is used in the initial noise handshake, so might be related to #5877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants