core: include AP handshake in 5s timeout

[kingosticks]

Inspired by #1456.

I bumped the timeout to 5s since we're doing more work now. And added a debug message so can tell if it's the connect or the handshake that died.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

[roderickvd]

Good idea, thanks.

[photovoltex]

I can understand the log message, but why would we increase the timeout?

since we're doing more work now

I think the timeout was just recently introduced (~4 Months) and during that time nothing around connecting to the access point changed, I think. So is there really a need to bump the timeout there? I think it probably will not make a big difference, but I would probably like to know what you meant by "more work"^^

[kingosticks]

We previously had a 3 second timeout for just connecting the socket. This was an arbitrary time I plucked from thin air that seemed to me way longer than any real system would need. This change moves the AP handshake messaging into the timeout protection. So now we're trying to do socket connect and AP handshake in the same 3 second timeout period i.e. more work. Rather than needlessly break any users that relied on the full 3 seconds for just connecting (!), I just bumped it up to 5 seconds for both. This seemed safer whilst still being useful.

[photovoltex]

Ah I see. Thanks for the clear up! I seem to have overlooked the move of the handshake.

[kingosticks]

OK to merge?

[photovoltex]

Yes, just one last thought from my side. Would it make sense to make the timeout customizable?

[kingosticks]

I don't think it's worth the bother but up to you.

[photovoltex]

Sounds good to me. Only wanted to throw the idea into the room :)

[kingosticks]

Thanks