Handle UI texts as Unicode#69
Merged
Merged
Conversation
slouken
reviewed
May 7, 2026
The text rendering code so far assumed all the characters can be represented each in a single byte. This means that the "COPYRIGHT SIGN" character in two UI definitions is encoded as ISO-8859. Tweak a bit the handling of the text, using SDL APIs to iterate through the codepoints as such (rather than byte by byte). While it works, it is still limited by the availability of characters in the fonts, which will likely not have anything more than what available in ISO-8859. As result, Data/UI/main.xml can be converted to UTF-8: $ iconv -f ISO-8859-15 -t UTF-8 -o Data/UI/main.xml Data/UI/main.xml
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text rendering code so far assumed all the characters can be represented each in a single byte. This means that the "COPYRIGHT SIGN" character in two UI definitions is encoded as ISO-8859.
Tweak a bit the handling of the text, using SDL APIs to iterate through the codepoints as such (rather than byte by byte). While it works, it is still limited by the availability of characters in the fonts, which will likely not have anything more than what available in ISO-8859.
As result,
Data/UI/main.xmlcan be converted to UTF-8: