Make it possible to use a system installation of PhysFS#75
Merged
Conversation
It is needed to use the imported targets features of the PkgConfig module.
Add a new USE_VENDORED_PHYSFS CMake variable to determine whether to use the vendored version of PhysFS (defauling to true to keep the existing behaviour). In case an external version is needed, detect it with pkg-config, as the CMake targets of a system PhysFS 3.2.0 do not seem to be fully usable. It can be changed later anyway. Fixes libsdl-org#68
Contributor
|
The point of using system physfs is to link with it dynamically. Otherwise you might as well use the vendored version, which has been tested with Maelstrom. Also, we can't bump CMake past 3.16, or it fails to build on various platforms. |
Contributor
Author
That's exactly what this PR is for:
No problem, 3.7 is more than enough for this. |
Contributor
|
Sorry, I totally misread this PR. Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
USE_VENDORED_PHYSFSCMake variable to determine whether to use the vendored version of PhysFS (defauling to true to keep the existing behaviour).In case an external version is needed, detect it with pkg-config, as the CMake targets of a system PhysFS 3.2.0 do not seem to be fully usable. It can be changed later anyway.
Bump the required CMake version to 3.7 to be able to use the imported targets in the
PkgConfigCMake module.Fixes #68