Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testautomation --filter render_testBlendModes fails with vulkan renderer #10400

Closed
madebr opened this issue Jul 28, 2024 · 3 comments
Closed
Assignees
Labels
icculus-priority Things @icculus is looking at within a larger milestone.
Milestone

Comments

@madebr
Copy link
Contributor

madebr commented Jul 28, 2024

Command:

test/testautomation  --filter render_testBlendModes --renderer vulkan

Grepping Failed, these assertions fail:

ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB color modulation operation results, expected 0,64,226,255, got 115,122,138,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB color modulation operation results, expected 0,64,226,255, got 115,122,138,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB alpha modulation operation results, expected 10,128,240,255, got 116,128,139,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB alpha modulation operation results, expected 10,128,240,255, got 116,128,139,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render point SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render line SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render rect SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,26': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,26': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render ARGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND operation results, expected 10,128,240,255, got 116,128,139,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND operation results, expected 10,128,240,255, got 116,128,139,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND_PREMULTIPLIED operation results, expected 10,128,240,255, got 125,243,255,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND_PREMULTIPLIED operation results, expected 10,128,240,255, got 125,243,255,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_ADD operation results, expected 138,255,255,255, got 129,141,152,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_ADD operation results, expected 138,255,255,128, got 129,141,152,128': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_MUL operation results, expected 5,64,120,255, got 120,179,235,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_MUL operation results, expected 5,64,120,128, got 120,179,235,128': Failed
@slouken slouken added this to the 3.2.0 milestone Jul 28, 2024
@slouken
Copy link
Collaborator

slouken commented Jul 28, 2024

I can repro with Vulkan as well as D3D. I'll have to check whether the software renderer or the 3D renderer is correct.

@slouken slouken added the icculus-priority Things @icculus is looking at within a larger milestone. label Jan 8, 2025
@icculus
Copy link
Collaborator

icculus commented Jan 13, 2025

These 4 also fail on Metal:

macbuildbot:buildbot icculus$ test/testautomation  --filter render_testBlendModes 2>&1 |grep Failed
2025-01-13 12:17:36.057 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render point SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
2025-01-13 12:17:36.058 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render line SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
2025-01-13 12:17:36.059 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render rect SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
2025-01-13 12:17:36.061 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render ARGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed

OpenGL and the software renderer pass everything.

The "gpu" backend passes everything, too, on both Metal and Vulkan.

@icculus icculus removed the icculus-priority Things @icculus is looking at within a larger milestone. label Jan 20, 2025
@slouken slouken added the icculus-priority Things @icculus is looking at within a larger milestone. label Jan 20, 2025
@slouken
Copy link
Collaborator

slouken commented Jan 20, 2025

9b454a7 fixes metal and the D3D renderers, and a036aed does the final step to fix this for Vulkan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icculus-priority Things @icculus is looking at within a larger milestone.
Projects
None yet
Development

No branches or pull requests

3 participants