[SDL3] Translate conditional effects direction instead of hardcoding it to 0 #12031
Conversation
Lawstorant
force-pushed
the
fix-conditional-direction
branch
from
d8c34b4 to
5422454
Compare
|
Sine function graph for context which shows the issue with using direction = 0:
|
Provious code wrongly assumed that direction is not an important part of conditional effect. Moreover, if there's need to hardcode polar direction, the default should be 0x4000 (north). For one axis affects, a direction of 0 means complete lack of force, if a FFB-enabled device takes direction into force calculation. A sine function graph can be used to represent the resulting forces where X is the input direction and Y is the force multiplier (360 degrees equals to 1). This fixes conditional effect playback on Moza Racing devices, which do not ignore direction field.
Lawstorant
force-pushed
the
fix-conditional-direction
branch
from
5422454 to
bfe6b5b
Compare
|
I think the wrong value came from confusion between spherical and polar systems where in the former, the proper value indeed would be 0, but Linux API uses polar. I see that the RUMBLE (LEFTRIGHT) effect is incorrectly initialised as well (again, direction = 0). Shall I add the fix to this PR or create a separate one? |
Feel free to add it to this PR. |
Uses proper polar direction of 90 degrees. Previous value probably came from mistakenly using spherical system default.
|
Merged, thanks! |
Description
Previous code wrongly assumed that direction is not an important part of conditional effect. Moreover, if there's need to hardcode polar direction, the default should be
0x4000(North).For one axis affects, a direction of 0 means complete lack of force, if a FFB-enabled device takes direction into force calculation. A sine function graph can be used to represent the resulting forces where X is the input direction and Y is the force multiplier (360 degrees equals to 1).
This fixes conditional effect playback on Moza Racing devices, which do not ignore direction field.