Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for textarea with field method #220 #341

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

simbabque
Copy link
Contributor

I couldn't reproduce this issue, but I've added tests.

Closes #220.

@simbabque simbabque requested a review from oalders July 28, 2022 12:30
Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I think one of the test labels was a victim of copy/paste?

@simbabque
Copy link
Contributor Author

Looks great. I think one of the test labels was a victim of copy/paste?

Yes, it was. Thanks for spotting that. I've pushed a new version.

@simbabque simbabque requested a review from oalders July 28, 2022 20:28
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #341 (41b14f7) into master (895a635) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files           3        3           
  Lines         850      850           
  Branches      231      231           
=======================================
  Hits          754      754           
  Misses         36       36           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895a635...41b14f7. Read the comment docs.

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@oalders oalders merged commit d0f2b80 into master Jul 28, 2022
@oalders oalders deleted the simbabque/gh-220 branch July 28, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROBLEM WITH FILLING TEXTAREA
2 participants