-
Notifications
You must be signed in to change notification settings - Fork 636
Add rosboard connection support #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add rosboard connection support #343
Conversation
|
This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open. |
|
Waiting for feedback from any contributor... |
|
Hey @charlielito! First of all sorry for the delay answering to this PR! I'd like to know if is it's possible to make your fork up to date with Lichtblick so the pipelines are updated and able to run here. Cheers, |
just updated the branch with the latest stuff |
Hey! Thanks for doing that! So im going to review the PR, but in the meanwhile could you fix the lint errors and other stuff that's making the pipelines fail? Adding some unit tests would be important too |
|
@charlielito gentle reminder |
|
This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open. |
|
I'll take a look |
User-Facing Changes
Add rosboard connection support
Description
We added a new type of connection that uses rosboard protocol to send live data way more lightweight than rosbridge or foxgloves' weksocket connector. For more details see our discourse post: https://discourse.ros.org/t/introducing-foxglove-integration-with-rosboard-for-real-time-visualizations/38376
It would be nice if the now open-source version of foxglove supported this so anyone could it as well. The only problem is that we had to modify rosboard in our fork for this integration and currently it supports only ROS2. What are your thoughts?
Checklist